Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
B
baas-ide
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
guxukai
baas-ide
Commits
99db93c8
Unverified
Commit
99db93c8
authored
Aug 29, 2019
by
yann300
Committed by
GitHub
Aug 29, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2292 from ethereum/statusUpdate
check for key is defined
parents
bb355c6b
2def63cc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
vertical-icons.js
src/app/components/vertical-icons.js
+1
-1
compile-tab.js
src/app/tabs/compile-tab.js
+1
-1
No files found.
src/app/components/vertical-icons.js
View file @
99db93c8
...
@@ -48,7 +48,7 @@ export class VerticalIcons extends Plugin {
...
@@ -48,7 +48,7 @@ export class VerticalIcons extends Plugin {
const
types
=
[
'error'
,
'warning'
,
'success'
,
'info'
,
''
]
const
types
=
[
'error'
,
'warning'
,
'success'
,
'info'
,
''
]
const
fn
=
(
status
)
=>
{
const
fn
=
(
status
)
=>
{
if
(
!
types
.
includes
(
status
.
type
)
&&
status
.
type
)
throw
new
Error
(
`type should be
${
keys
.
join
()}
`
)
if
(
!
types
.
includes
(
status
.
type
)
&&
status
.
type
)
throw
new
Error
(
`type should be
${
keys
.
join
()}
`
)
if
(
!
status
.
key
)
throw
new
Error
(
`status key should be defined`
)
if
(
status
.
key
===
undefined
)
throw
new
Error
(
`status key should be defined`
)
if
(
typeof
status
.
key
===
'string'
&&
(
!
keys
.
includes
(
status
.
key
)))
{
if
(
typeof
status
.
key
===
'string'
&&
(
!
keys
.
includes
(
status
.
key
)))
{
throw
new
Error
(
'key should contain either number or '
+
keys
.
join
())
throw
new
Error
(
'key should contain either number or '
+
keys
.
join
())
...
...
src/app/tabs/compile-tab.js
View file @
99db93c8
...
@@ -114,7 +114,7 @@ class CompileTab extends ViewPlugin {
...
@@ -114,7 +114,7 @@ class CompileTab extends ViewPlugin {
if
(
success
)
{
if
(
success
)
{
// forwarding the event to the appManager infra
// forwarding the event to the appManager infra
this
.
emit
(
'compilationFinished'
,
source
.
target
,
source
,
'soljson'
,
data
)
this
.
emit
(
'compilationFinished'
,
source
.
target
,
source
,
'soljson'
,
data
)
if
(
data
.
errors
)
{
if
(
data
.
errors
&&
data
.
errors
.
length
>
0
)
{
this
.
emit
(
'statusChanged'
,
{
this
.
emit
(
'statusChanged'
,
{
key
:
data
.
errors
.
length
,
key
:
data
.
errors
.
length
,
title
:
`compilation finished successful with warning
${
data
.
errors
.
length
>
1
?
's'
:
''
}
`
,
title
:
`compilation finished successful with warning
${
data
.
errors
.
length
>
1
?
's'
:
''
}
`
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment