Unverified Commit 6ec50ea8 authored by yann300's avatar yann300 Committed by GitHub

Merge pull request #2375 from ethereum/fix_gist_hanlder_files_duplication

Make sure file from gist handler are not duplicated
parents 6d3374f8 e335b3f5
......@@ -342,11 +342,18 @@ class FileManager extends Plugin {
}
}
setBatchFiles (filesSet, fileProvider, callback) {
setBatchFiles (filesSet, fileProvider, override, callback) {
const self = this
if (!fileProvider) fileProvider = 'browser'
if (override === undefined) override = false
async.each(Object.keys(filesSet), (file, callback) => {
if (override) {
self._deps.filesProviders[fileProvider].set(file, filesSet[file].content)
self.syncEditor(fileProvider + file)
return callback()
}
helper.createNonClashingName(file, self._deps.filesProviders[fileProvider],
(error, name) => {
if (error) {
......@@ -355,11 +362,11 @@ class FileManager extends Plugin {
modalDialogCustom.alert('Special characters are not allowed')
} else {
self._deps.filesProviders[fileProvider].set(name, filesSet[file].content)
self.syncEditor(fileProvider + name)
}
callback()
})
}, (error) => {
if (!error) self.switchFile()
if (callback) callback(error)
})
}
......
......@@ -57,7 +57,7 @@ function GistHandler (_window) {
Object.keys(data.files).forEach((element) => {
obj['/gists/' + gistId + '/' + element] = data.files[element]
})
fileManager.setBatchFiles(obj, 'browser', (errorLoadingFile) => {
fileManager.setBatchFiles(obj, 'browser', true, (errorLoadingFile) => {
if (!errorLoadingFile) {
gistProvider.id = gistId
gistProvider.origGistFiles = data.files
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment