add comment + misc

ci/makeMockCompiler.js

@@ -16,21 +16,19 @@ gatherCompilationResults(function (error, data) {
 
 function gatherCompilationResults (callback) {
   var compilationResult = {}
-  fs.readdir('./test-browser/tests', 'utf8', function (error, data) {
+  fs.readdir('./test-browser/tests', 'utf8', function (error, filenames) {
     if (error) {
       console.log(error)
       process.exit(1)
     } else {
-      data.map(function (item, i) {
+      filenames.map(function (item, i) {
         var testDef = require('../test-browser/tests/' + item)
-        for (var k in testDef) {
-          if (k === '@Sources') {
-            var source = testDef[k]()
-            var result = compile(source, 1)
-            compilationResult[result.key] = result
-            result = compile(source, 0)
-            compilationResult[result.key] = result
-          }
+        if ('@sources' in testDef) {
+          var source = testDef['@sources']()
+          var result = compile(source, 1)
+          compilationResult[result.key] = result
+          result = compile(source, 0)
+          compilationResult[result.key] = result
         }
       })
 

src/app/editor.js

@@ -12,7 +12,7 @@ function Editor (loadingFromGist, storage) {
   var SOL_CACHE_FILE = null
 
   var editor = ace.edit('input')
-  document.getElementById('input').editor = editor
+  document.getElementById('input').editor = editor // required to access the editor during tests
   var sessions = {}
   var sourceAnnotations = []
 

test-browser/helpers/applytestmode.js

@@ -3,5 +3,5 @@
  *
  */
 console.log('applying test mode')
-document.getElementById('input').editor.setBehavioursEnabled(false)
+document.getElementById('input').editor.setBehavioursEnabled(false) // disable bracket auto-match (i.e. automatic injection of closing brackets and other things), so we can enter raw source code.
 console.log('test mode applied')

test-browser/helpers/contracts.js

@@ -7,7 +7,6 @@ module.exports = {
 
 function checkCompiledContracts (browser, compiled, callback) {
   browser.elements('css selector', '.udapp .contract .title', function (elements) {
-    console.log(JSON.stringify(elements))
     elements.value.map(function (item, i) {
       browser.elementIdText(item.ELEMENT, function (text) {
         browser.assert.equal(text.value.split('\n')[0], compiled[i])
@@ -22,6 +21,6 @@ function testContracts (browser, contractCode, compiledContractNames, callback)
       .clearValue('#input textarea')
       .click('.newFile')
       .setValue('#input textarea', contractCode, function () {})
-      .waitForElementPresent('.contract .create', 3000000)
+      .waitForElementPresent('.contract .create', 2000)
   checkCompiledContracts(browser, compiledContractNames, callback)
 }

test-browser/tests/ballot.js

@@ -13,7 +13,7 @@ module.exports = {
   before: function (browser, done) {
     init(browser, done)
   },
-  '@Sources': function () {
+  '@sources': function () {
     return sources
   },
   'Ballot': function (browser) {

test-browser/tests/simpleContract.js

@@ -12,7 +12,7 @@ module.exports = {
   before: function (browser, done) {
     init(browser, done)
   },
-  '@Sources': function () {
+  '@sources': function () {
     return sources
   },
   'Simple Contract': function (browser) {