A little more compiler cleanup

src/app.js

@@ -20,8 +20,6 @@ window.addEventListener("message", function(ev) {
 	}
 }, false);
 
-var Base64 = require('js-base64').Base64;
-
 var run = function() {
 
 	// ------------------ query params (hash) ----------------
@@ -446,12 +444,8 @@ var run = function() {
 	// ----------------- compiler output renderer ----------------------
 	var detailsOpen = {};
 
-	function errortype(message) {
-		return message.match(/^.*:[0-9]*:[0-9]* Warning: /) ? 'warning' : 'error';
-	}
-
 	var renderError = function(message) {
-		var type = errortype(message);
+		var type = utils.errortype(message);
 		var $pre = $("<pre />").text(message);
 		var $error = $('<div class="sol ' + type + '"><div class="close"><i class="fa fa-close"></i></div></div>').prepend($pre);
 		$('#output').append( $error );
@@ -665,7 +659,7 @@ var run = function() {
     return $.getJSON('https://api.github.com/repos/' + root + '/contents/' + path, cb);
 	}
 
-	var compiler = new Compiler(editor, renderContracts, renderError, errortype, handleGithubCall, $('#output'), function() { return hidingRHP; });
+	var compiler = new Compiler(editor, renderContracts, renderError, handleGithubCall, $('#output'), function() { return hidingRHP; });
 
 	function setVersionText(text) {
 		$('#version').text(text);

src/app/compiler.js

 var queryParams = require('./query-params');
 var utils = require('./utils');
 
-function Compiler(editor, renderContracts, renderError, errortype, handleGithubCall, outputField, hidingRHP) {
+var Base64 = require('js-base64').Base64;
+
+function Compiler(editor, renderContracts, renderError, handleGithubCall, outputField, hidingRHP) {
 
   var compileJSON;
   var compilerAcceptsMultipleFiles;
@@ -108,12 +110,12 @@ function Compiler(editor, renderContracts, renderError, errortype, handleGithubC
 
     if (data['error'] !== undefined) {
       renderError(data['error']);
-      if (errortype(data['error']) !== 'warning') noFatalErrors = false;
+      if (utils.errortype(data['error']) !== 'warning') noFatalErrors = false;
     }
     if (data['errors'] != undefined) {
       data['errors'].forEach(function(err) {
         renderError(err);
-        if (errortype(err) !== 'warning') noFatalErrors = false;
+        if (utils.errortype(err) !== 'warning') noFatalErrors = false;
       });
     }
 

src/app/utils.js

@@ -12,8 +12,13 @@ function fileNameFromKey(key) {
   return key.replace( getCacheFilePrefix(), '' );
 }
 
+function errortype(message) {
+  return message.match(/^.*:[0-9]*:[0-9]* Warning: /) ? 'warning' : 'error';
+}
+
 module.exports = {
   getCacheFilePrefix: getCacheFilePrefix,
   fileKey: fileKey,
-  fileNameFromKey: fileNameFromKey
+  fileNameFromKey: fileNameFromKey,
+  errortype: errortype
 };