Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
B
baas-ide
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
guxukai
baas-ide
Commits
1d41f4e6
Commit
1d41f4e6
authored
Nov 29, 2019
by
LianaHus
Committed by
Liana Husikyan
Dec 03, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
workers should be used only with whitelisted versions for chrome
parent
a690ab2e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
33 additions
and
5 deletions
+33
-5
compilerContainer.js
src/app/tabs/compileTab/compilerContainer.js
+33
-5
No files found.
src/app/tabs/compileTab/compilerContainer.js
View file @
1d41f4e6
...
@@ -376,11 +376,31 @@ class CompilerContainer {
...
@@ -376,11 +376,31 @@ class CompilerContainer {
}
}
url
=
`
${
this
.
data
.
baseurl
}
/
${
this
.
data
.
selectedVersion
}
`
url
=
`
${
this
.
data
.
baseurl
}
/
${
this
.
data
.
selectedVersion
}
`
}
}
// Check if browser is compatible with web worker
if
(
this
.
browserSupportWorker
)
{
// Following restrictions should be deleted when Solidity will release fixed versions of compilers.
// Workers cannot load js on "file:"-URLs and we get a
// See https://github.com/ethereum/remix-ide/issues/2461
// "Uncaught RangeError: Maximum call stack size exceeded" error on Chromium,
const
isChrome
=
!!
window
.
chrome
// resort to non-worker version in that case.
const
os
=
this
.
_retrieveOS
()
// define a whitelist for Linux
const
linuxWL
=
[
'0.4.26'
,
'0.5.3'
,
'0.5.4'
,
'0.5.5'
]
const
version
=
semver
.
coerce
(
this
.
data
.
selectedVersion
)
// defining whitelist for chrome
let
isFromWhiteList
=
false
switch
(
os
)
{
case
'Windows'
:
isFromWhiteList
=
semver
.
gt
(
version
,
'0.5.2'
)
||
version
===
'0.4.26'
break
case
'Linux'
:
isFromWhiteList
=
semver
.
gt
(
version
,
'0.5.13'
)
||
linuxWL
.
includes
(
version
)
break
default
:
isFromWhiteList
=
true
}
// Workers cannot load js on "file:"-URLs and we get a
// "Uncaught RangeError: Maximum call stack size exceeded" error on Chromium,
// resort to non-worker version in that case.
if
(
this
.
browserSupportWorker
&&
(
!
isChrome
||
(
isChrome
&&
isFromWhiteList
)))
{
this
.
compileTabLogic
.
compiler
.
loadVersion
(
true
,
url
)
this
.
compileTabLogic
.
compiler
.
loadVersion
(
true
,
url
)
this
.
setVersionText
(
'(loading using worker)'
)
this
.
setVersionText
(
'(loading using worker)'
)
}
else
{
}
else
{
...
@@ -389,6 +409,14 @@ class CompilerContainer {
...
@@ -389,6 +409,14 @@ class CompilerContainer {
}
}
}
}
_retrieveOS
()
{
let
osName
=
'Unknown OS'
if
(
navigator
.
appVersion
.
indexOf
(
'Win'
)
!==
-
1
)
osName
=
'Windows'
if
(
navigator
.
appVersion
.
indexOf
(
'Mac'
)
!==
-
1
)
osName
=
'MacOS'
if
(
navigator
.
appVersion
.
indexOf
(
'Linux'
)
!==
-
1
)
osName
=
'Linux'
return
osName
}
_updateLanguageSelector
()
{
_updateLanguageSelector
()
{
// This is the first version when Yul is available
// This is the first version when Yul is available
if
(
!
semver
.
valid
(
this
.
_retrieveVersion
())
||
semver
.
lt
(
this
.
_retrieveVersion
(),
'v0.5.7+commit.6da8b019.js'
))
{
if
(
!
semver
.
valid
(
this
.
_retrieveVersion
())
||
semver
.
lt
(
this
.
_retrieveVersion
(),
'v0.5.7+commit.6da8b019.js'
))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment