修改upgrade裁剪版mavl存在的bug，以及同步过程中删除裁剪版mavl减少磁盘占用

plugin/store/kvmvccmavl/kvmvcc_mavl.go

@@ -34,7 +34,8 @@ var (
 	delMavlDataState   int32
 	wg                 sync.WaitGroup
 	quit               bool
-	isUpgradeCommitMavl bool
+	isPrunedMavl       bool                       // 是否是被裁剪过的 mavl
+	delPrunedMavlState int32 = delPrunedMavlStart // Upgrade时候删除pruned mavl的状态
 )
 
 const (
@@ -42,6 +43,10 @@ const (
 	batchDataSize     = 1024 * 1024 * 1
 	delMavlStateStart = 1
 	delMavlStateEnd   = 0
+
+	delPrunedMavlStart    = 0
+	delPrunedMavlStarting = 1
+	delPruneMavlEnd       = 2
 )
 
 // SetLogLevel set log level
@@ -128,8 +133,8 @@ func New(cfg *types.Store, sub []byte) queue.Module {
 	if err == nil {
 		isDelMavlData = true
 	}
-	// 查询是Upgrade是否需保存mavl
-	isUpgradeCommitMavl = isCommitMavlDB(bs.GetDB())
+	// 查询是Upgrade,需要存储mavl到db
+	isPrunedMavl = isPrunedMavlDB(bs.GetDB())
 
 	bs.SetChild(kvms)
 	return kvms
@@ -269,7 +274,7 @@ func (kvmMavls *KVmMavlStore) MemSetUpgrade(datas *types.StoreSet, sync bool) ([
 		var hash []byte
 		var err error
 
-		if isUpgradeCommitMavl {
+		if isPrunedMavl {
 			hash, err = kvmMavls.MavlStore.MemSet(datas, sync)
 			if err != nil {
 				return hash, err
@@ -301,8 +306,12 @@ func (kvmMavls *KVmMavlStore) MemSetUpgrade(datas *types.StoreSet, sync bool) ([
 func (kvmMavls *KVmMavlStore) CommitUpgrade(req *types.ReqHash) ([]byte, error) {
 	var hash []byte
 	var err error
-	if isUpgradeCommitMavl {
+	if isPrunedMavl {
 		hash, err = kvmMavls.Commit(req)
+		if isNeedDelPrunedMavl() {
+			wg.Add(1)
+			go deletePrunedMavl(kvmMavls.GetDB())
+		}
 	} else {
 		hash, err = kvmMavls.KVMVCCStore.CommitUpgrade(req)
 	}
@@ -381,7 +390,18 @@ func setDelMavl(state int32) {
 	atomic.StoreInt32(&delMavlDataState, state)
 }
 
-func isCommitMavlDB(db dbm.DB) bool {
+func isNeedDelPrunedMavl() bool {
+	if atomic.LoadInt32(&delPrunedMavlState) == 0 {
+		return true
+	}
+	return false
+}
+
+func setDelPrunedMavl(state int32) {
+	atomic.StoreInt32(&delPrunedMavlState, state)
+}
+
+func isPrunedMavlDB(db dbm.DB) bool {
 	prefix := []byte(leafNodePrefix)
 	it := db.Iterator(prefix, nil, true)
 	defer it.Close()
@@ -393,3 +413,34 @@ func isCommitMavlDB(db dbm.DB) bool {
 	}
 	return isCommit
 }
+
+func deletePrunedMavl(db dbm.DB) {
+	defer wg.Done()
+	setDelPrunedMavl(delPrunedMavlStarting)
+	defer setDelPrunedMavl(delPruneMavlEnd)
+
+	deletePrunedMavlData(db, hashNodePrefix)
+	deletePrunedMavlData(db, leafNodePrefix)
+	deletePrunedMavlData(db, leafKeyCountPrefix)
+	deletePrunedMavlData(db, oldLeafKeyCountPrefix)
+}
+
+func deletePrunedMavlData(db dbm.DB, prefix string) {
+	it := db.Iterator([]byte(prefix), nil, true)
+	defer it.Close()
+	if it.Rewind() && it.Valid() {
+		batch := db.NewBatch(false)
+		for it.Next(); it.Valid(); it.Next() { //第一个不做删除
+			if quit {
+				return
+			}
+			batch.Delete(it.Key())
+			if batch.ValueSize() > batchDataSize {
+				batch.Write()
+				batch.Reset()
+				time.Sleep(time.Millisecond * 100)
+			}
+		}
+		batch.Write()
+	}
+}

plugin/store/kvmvccmavl/kvmvcc_mavl_test.go

@@ -720,15 +720,46 @@ func TestIsCommitMavl(t *testing.T) {
 	store := New(storeCfg, nil).(*KVmMavlStore)
 	assert.NotNil(t, store)
 
-	isComm := isCommitMavlDB(store.GetDB())
+	isComm := isPrunedMavlDB(store.GetDB())
 	require.Equal(t, false, isComm)
 
 	store.GetDB().Set([]byte(fmt.Sprintln(leafNodePrefix, "123")), []byte("v1"))
 	store.GetDB().Set([]byte(fmt.Sprintln(leafNodePrefix, "456")), []byte("v2"))
-	isComm = isCommitMavlDB(store.GetDB())
+	isComm = isPrunedMavlDB(store.GetDB())
 	require.Equal(t, true, isComm)
 }
 
+func TestDeletePrunedMavl(t *testing.T) {
+	dir, err := ioutil.TempDir("", "example")
+	assert.Nil(t, err)
+	defer os.RemoveAll(dir) // clean up
+	os.RemoveAll(dir)       //删除已存在目录
+	storeCfg := newStoreCfg(dir)
+	store := New(storeCfg, nil).(*KVmMavlStore)
+	assert.NotNil(t, store)
+
+	deletePrunedMavlData(store.GetDB(), hashNodePrefix)
+	store.GetDB().Set([]byte(fmt.Sprintln(hashNodePrefix, "123")), []byte("v1"))
+
+	//测试只有一条数据时候, 则不做删除
+	deletePrunedMavlData(store.GetDB(), hashNodePrefix)
+	v1, err := store.GetDB().Get([]byte(fmt.Sprintln(hashNodePrefix, "123")))
+	require.NoError(t, err)
+	require.Equal(t, v1, []byte("v1"))
+
+	//测试再加入一条数据，即两条时候
+	store.GetDB().Set([]byte(fmt.Sprintln(hashNodePrefix, "456")), []byte("v2"))
+	deletePrunedMavlData(store.GetDB(), hashNodePrefix)
+
+	v1, err = store.GetDB().Get([]byte(fmt.Sprintln(hashNodePrefix, "123")))
+	require.Error(t, err)
+	require.Equal(t, v1, []uint8([]byte(nil)))
+	v2, err := store.GetDB().Get([]byte(fmt.Sprintln(hashNodePrefix, "456")))
+	require.NoError(t, err)
+	require.Equal(t, v2, []byte("v2"))
+
+}
+
 func BenchmarkGetkmvccMavl(b *testing.B) { benchmarkGet(b, false) }
 func BenchmarkGetkmvcc(b *testing.B)     { benchmarkGet(b, true) }
 

plugin/store/kvmvccmavl/mavl.go

@@ -16,7 +16,10 @@ import (
 
 const (
 	// 同store/mavl中定义保持一致，即裁剪的加前缀
+	hashNodePrefix        = "_mh_"
 	leafNodePrefix        = "_mb_"
+	leafKeyCountPrefix    = "..mk.."
+	oldLeafKeyCountPrefix = "..mok.."
 )
 
 // MavlStore mavl store struct

vendor/github.com/33cn/chain33/system/store/mavl/db/tree.go

@@ -205,7 +205,7 @@ func (t *Tree) Save() []byte {
 		return nil
 	}
 	if t.ndb != nil {
-		if t.isRemoveLeafCountKey() {
+		if enablePrune && t.isRemoveLeafCountKey() {
 			//DelLeafCountKV 需要先提前将leafcoutkey删除,这里需先于t.ndb.Commit()
 			err := DelLeafCountKV(t.ndb.db, t.blockHeight)
 			if err != nil {