Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
B
baas-ide
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
guxukai
baas-ide
Commits
565ac112
Unverified
Commit
565ac112
authored
Apr 14, 2020
by
yann300
Committed by
GitHub
Apr 14, 2020
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2725 from ethereum/firefox-libraryDeployment
Fix Failing Library Deployment Test
parents
3653a38d
6bd38be7
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
4 deletions
+8
-4
universal-dapp-ui.js
src/app/ui/universal-dapp-ui.js
+1
-1
getAddressAtPosition.js
test-browser/commands/getAddressAtPosition.js
+6
-3
libraryDeployment.js
test-browser/tests/libraryDeployment.js
+1
-0
No files found.
src/app/ui/universal-dapp-ui.js
View file @
565ac112
...
...
@@ -54,7 +54,7 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address
let
self
=
this
address
=
(
address
.
slice
(
0
,
2
)
===
'0x'
?
''
:
'0x'
)
+
address
.
toString
(
'hex'
)
address
=
ethJSUtil
.
toChecksumAddress
(
address
)
var
instance
=
yo
`<div class="instance run-instance border-dark
${
css
.
instance
}
${
css
.
hidesub
}
" id="instance
${
address
}
"></div>`
var
instance
=
yo
`<div class="instance run-instance border-dark
${
css
.
instance
}
${
css
.
hidesub
}
" id="instance
${
address
}
"
data-shared="universalDappUiInstance"
></div>`
const
context
=
this
.
blockchain
.
context
()
var
shortAddress
=
helper
.
shortenAddress
(
address
)
...
...
test-browser/commands/getAddressAtPosition.js
View file @
565ac112
...
...
@@ -14,9 +14,12 @@ class GetAddressAtPosition extends EventEmitter {
}
function
getAddressAtPosition
(
browser
,
index
,
callback
)
{
index
=
index
+
2
browser
.
execute
(
function
(
index
)
{
return
document
.
querySelector
(
'.instance:nth-of-type('
+
index
+
')'
).
getAttribute
(
'id'
).
replace
(
'instance'
,
''
)
browser
.
waitForElementPresent
(
'*[data-shared="universalDappUiInstance"]'
)
.
execute
(
function
(
index
)
{
const
deployedContracts
=
document
.
querySelectorAll
(
'*[data-shared="universalDappUiInstance"]'
)
const
id
=
deployedContracts
[
index
].
getAttribute
(
'id'
)
return
id
.
replace
(
'instance'
,
''
)
},
[
index
],
function
(
result
)
{
callback
(
result
.
value
)
})
...
...
test-browser/tests/libraryDeployment.js
View file @
565ac112
...
...
@@ -52,6 +52,7 @@ module.exports = {
})
})
})
.
end
()
},
tearDown
:
sauce
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment