Unverified Commit 565ac112 authored by yann300's avatar yann300 Committed by GitHub

Merge pull request #2725 from ethereum/firefox-libraryDeployment

Fix Failing Library Deployment Test
parents 3653a38d 6bd38be7
...@@ -54,7 +54,7 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address ...@@ -54,7 +54,7 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address
let self = this let self = this
address = (address.slice(0, 2) === '0x' ? '' : '0x') + address.toString('hex') address = (address.slice(0, 2) === '0x' ? '' : '0x') + address.toString('hex')
address = ethJSUtil.toChecksumAddress(address) address = ethJSUtil.toChecksumAddress(address)
var instance = yo`<div class="instance run-instance border-dark ${css.instance} ${css.hidesub}" id="instance${address}"></div>` var instance = yo`<div class="instance run-instance border-dark ${css.instance} ${css.hidesub}" id="instance${address}" data-shared="universalDappUiInstance"></div>`
const context = this.blockchain.context() const context = this.blockchain.context()
var shortAddress = helper.shortenAddress(address) var shortAddress = helper.shortenAddress(address)
......
...@@ -14,9 +14,12 @@ class GetAddressAtPosition extends EventEmitter { ...@@ -14,9 +14,12 @@ class GetAddressAtPosition extends EventEmitter {
} }
function getAddressAtPosition (browser, index, callback) { function getAddressAtPosition (browser, index, callback) {
index = index + 2 browser.waitForElementPresent('*[data-shared="universalDappUiInstance"]')
browser.execute(function (index) { .execute(function (index) {
return document.querySelector('.instance:nth-of-type(' + index + ')').getAttribute('id').replace('instance', '') const deployedContracts = document.querySelectorAll('*[data-shared="universalDappUiInstance"]')
const id = deployedContracts[index].getAttribute('id')
return id.replace('instance', '')
}, [index], function (result) { }, [index], function (result) {
callback(result.value) callback(result.value)
}) })
......
...@@ -52,6 +52,7 @@ module.exports = { ...@@ -52,6 +52,7 @@ module.exports = {
}) })
}) })
}) })
.end()
}, },
tearDown: sauce tearDown: sauce
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment